Skip to content

This PR is to add comments to TestJindoEngine_DeleteVolume in pkg\ddc\jindo\delete_volume_test.go.#4570

Merged
fluid-e2e-bot[bot] merged 1 commit intofluid-cloudnative:masterfrom
DreamStars1:new-branch1
Mar 13, 2025
Merged

This PR is to add comments to TestJindoEngine_DeleteVolume in pkg\ddc\jindo\delete_volume_test.go.#4570
fluid-e2e-bot[bot] merged 1 commit intofluid-cloudnative:masterfrom
DreamStars1:new-branch1

Conversation

@DreamStars1
Copy link
Copy Markdown
Contributor

Ⅰ. Describe what this PR does

Add notation to TestJindoEngine_DeleteVolume in pkg\ddc\jindo\delete_volume_test.go.

Ⅱ. Does this pull request fix one issue?

fixes #4569

…volume_test.go.

Signed-off-by: Haipei Zheng <3300877412@qq.com>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 7, 2025

Hi @DreamStars1. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 7, 2025

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot Bot merged commit 59b3713 into fluid-cloudnative:master Mar 13, 2025
12 checks passed
Elaina42 pushed a commit to Elaina42/fluid that referenced this pull request Mar 14, 2025
…volume_test.go. (fluid-cloudnative#4570)

Signed-off-by: Haipei Zheng <3300877412@qq.com>
Signed-off-by: kl <221220103@smail.nju.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add notation to TestJindoEngine_DeleteVolume in pkg\ddc\jindo\delete_volume_test.go.

2 participants